Re: [PATCH] tty: preparatory structures for termios revamp

From: David Woodhouse
Date: Thu Oct 19 2006 - 02:45:40 EST


On Wed, 2006-10-18 at 18:39 +0100, Alan Cox wrote:
> In order to sort out our struct termios and add proper speed control we
> need to separate the kernel and user termios structures. Glibc is fine
> but the other libraries rely on the kernel exported struct termios and
> we need to extend this without breaking the ABI/API
>
> To do so we add a struct ktermios which is the kernel view of a termios
> structure and overlaps the struct termios with extra fields on the end
> for now. (That limitation will go away in later patches). Some platforms
> (eg alpha) planned ahead and thus use the same struct for both, others
> did not.
>
>
> This just adds the structures but does not use them, it seems a sensible
> splitting point for bisect if there are compile failures (not that I
> expect them)

Why have separate copies of almost identical structures in each
architecture -- can we not put the new structure in
asm-generic/termbits.h and use that for all but SPARC, which has the
extra _x_cc field?

--
dwmw2

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/