Re: + i386-time-avoid-pit-smp-lockups.patch added to -mm tree

From: Daniel Walker
Date: Thu Oct 19 2006 - 09:44:59 EST


On Wed, 2006-10-11 at 14:26 -0700, akpm@xxxxxxxx wrote:

> diff -puN arch/i386/kernel/i8253.c~i386-time-avoid-pit-smp-lockups arch/i386/kernel/i8253.c
> --- a/arch/i386/kernel/i8253.c~i386-time-avoid-pit-smp-lockups
> +++ a/arch/i386/kernel/i8253.c
> @@ -109,7 +109,7 @@ static struct clocksource clocksource_pi
>
> static int __init init_pit_clocksource(void)
> {
> - if (num_possible_cpus() > 4) /* PIT does not scale! */
> + if (num_possible_cpus() > 1) /* PIT does not scale! */
> return 0;
>

Can we ifdef some code here on CONFIG_SMP . It bugs me that there just
dead code laying around on smp systems.

Daniel

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/