Re: [PATCH 1/1 try #2] Char: correct pci_get_device changes
From: Greg KH
Date: Thu Oct 19 2006 - 16:34:49 EST
On Thu, Oct 19, 2006 at 04:44:31PM +0200, Jiri Slaby wrote:
> correct pci_get_device changes
>
> Commits 881a8c120acf7ec09c90289e2996b7c70f51e996 and
> efe1ec27837d6639eae82e1f5876910ba6433c3f corrects pci device matching in
> only one way; it no longer oopses/crashes, despite hotplug is not solved in
> these changes.
>
> Whenever pci_find_device -> pci_get_device change is performed, also
> pci_dev_get and pci_dev_put should be in most cases called to properly
> handle hotplug. This patch does exactly this thing -- increase refcount to
> let kernel know, that we are using this piece of HW just now.
>
> It affects moxa and rio char drivers.
>
> Cc: <R.E.Wolff@xxxxxxxxxxxx>
> Cc: Amit Gud <gud@xxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxx>
> Cc: Alan Cox <alan@xxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Jiri Slaby <jirislaby@xxxxxxxxx>
Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxx>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/