Re: [PATCH 1/2] VFS: Make d_materialise_unique() enforce directoryuniqueness

From: Trond Myklebust
Date: Thu Oct 19 2006 - 17:01:00 EST


On Thu, 2006-10-19 at 22:51 +0200, Miklos Szeredi wrote:
> > From: Trond Myklebust <Trond.Myklebust@xxxxxxxxxx>
> >
> > If the caller tries to instantiate a directory using an inode that already
> > has a dentry alias, then we attempt to rename the existing dentry instead
> > of instantiating a new one. Fail with an ELOOP error if the rename would
> > affect one of our parent directories.
> >
> > This behaviour is needed in order to avoid issues such as
> >
> > http://bugzilla.kernel.org/show_bug.cgi?id=7178
> >
>
> This looks like a stale patch. You posted one on -fsdevel that did
> i_mutex locking as well.

Argh! Thanks for spotting that Miklos... I had forgotten to update my
'fixes' stgit branch with the newer version. Please discard the previous
version of this patch, Linus. I'll resend...

Cheers,
Trond
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/