Re: [PATCH 4/6] net: use bitrev8

From: Akinobu Mita
Date: Thu Oct 19 2006 - 22:50:27 EST


On Thu, Oct 19, 2006 at 01:39:51PM -0700, Andrew Morton wrote:

> A bunch of drivers.
>
> > ===================================================================
> > --- work-fault-inject.orig/drivers/net/Kconfig
> > +++ work-fault-inject/drivers/net/Kconfig
> > @@ -2500,6 +2500,7 @@ config DEFXX
> > config SKFP
> > tristate "SysKonnect FDDI PCI support"
> > depends on FDDI && PCI
> > + select BITREVERSE
> > ---help---
> > Say Y here if you have a SysKonnect FDDI PCI adapter.
> > The following adapters are supported by this driver:
>
> But only one of them selects the library.

Other drivers already select CRC32 and CRC32 selects BITREVERSE.

> But select is problematic and I do wonder whether it'd be simpler to just
> link the thing into vmlinux.

OK. I'll try.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/