Re: [PATCH] slab debug and ARCH_SLAB_MINALIGN don't get along

[Pekka Enberg]

Hi Kevin,

On 10/19/06, Kevin Hilman <khilman@xxxxxxxxxx> wrote:
> When CONFIG_SLAB_DEBUG is used in combination with ARCH_SLAB_MINALIGN,
> some debug flags should be disabled which depend on BYTES_PER_WORD
> alignment.
>
> The disabling of these debug flags is not properly handled when
> BYTES_PER_WORD < ARCH_SLAB_MEMALIGN < cache_line_size()
>
> This patch fixes that and also adds an alignment check to
> cache_alloc_debugcheck_after() when ARCH_SLAB_MINALIGN is used.

You forgot to mention which case you are fixing in the patch
description (that is, SLAB_HWCACHE_ALIGN, when cache_line_size() >
BYTES_PER_WORD) which made the patch bit hard to decipher. Anyway,
looks good, thanks!

                                             Pekka
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/