Re: [PATCH 2/3] netpoll: rework skb transmit queue

From: Andi Kleen
Date: Fri Oct 20 2006 - 17:16:32 EST


On Friday 20 October 2006 23:08, David Miller wrote:
> From: Andi Kleen <ak@xxxxxxx>
> Date: Fri, 20 Oct 2006 23:01:29 +0200
>
> > netpoll always played a little fast'n'lose with various locking rules.
>
> The current code is fine, it never reenters ->poll, because it
> maintains a "->poll_owner" which it checks in netpoll_send_skb()
> before trying to call back into ->poll.

I was more thinking of reentry of the interrupt handler in
the driver etc. A lot of them also do printk, but that is fortunately
caught higher level.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/