Re: [PATCH] x86-64: typo in __assign_irq_vector when updating pos for vector and offset

[Eric W. Biederman]

Muli Ben-Yehuda <muli@xxxxxxxxxx> writes:

> On Sat, Oct 21, 2006 at 09:00:17PM +0000, Linux Kernel Mailing List wrote:
>
>> commit 45edfd1db02f818b3dc7e4743ee8585af6b78f78
>> tree cc7a524069ee23c49237c417299e5aa2f93205e0
>> parent 926fafebc48a3218fac675f12974f9a46473bd40
>> author Yinghai Lu <yinghai.lu@xxxxxxx> 1161448621 +0200
>> committer Andi Kleen <andi@xxxxxxxxxxxxxxxxx> 1161448621 +0200
>> 
>> [PATCH] x86-64: typo in __assign_irq_vector when updating pos for vector and
> offset
>> 
>> typo with cpu instead of new_cpu
>
> This patch breaks my x366 machine:
>  
> aic94xx: device 0000:01:02.0: SAS addr 5005076a0112df00, PCBA SN , 8 phys, 8
> enabled phys, flash present, BIOS build 1323
> aic94xx: couldn't get irq 25 for 0000:01:02.0
> ACPI: PCI interrupt for device 0000:01:02.0 disabled
> aic94xx: probe of 0000:01:02.0 failed with error -38
>
> Reverting it allows it to boot again. Since the patch is "obviously
> correct", it must be uncovering some other problem with the genirq
> code.
>

Ugh.  This is no fun at all.  I am assuming this is with cpu hotplug
disabled in flat mode.

I need to step back and read the code but it appears that
request_irq(25) is failing.
Which implies that the vector assignment is failing for some strange
reason.

So what we need to do is figure out what those data structures
look like on your machine and see if we can figure out a plausible
explanation for why there would be no free vectors.

Taking a wild stab in the dark my hunch it is this bit of code that is
failing.
		for_each_cpu_mask(new_cpu, domain)
			if (per_cpu(vector_irq, new_cpu)[vector] != -1)
				goto next;

Which would suggest that vector_irq is improperly setup on one of the cpus
I am looking at.  It might be something stupid like I need to filter
domain with cpu_online_map.

If my wild set of hypothesis are true the patch below might make those
symptoms go away.  It isn't a real fix by any means but it is an
easy test patch I can generate to generate these giant leaps 
of deduction, I'm taking in the middle of the night :)

Eric


diff --git a/arch/x86_64/kernel/genapic_flat.c b/arch/x86_64/kernel/genapic_flat.c
index 7c01db8..986fa4b 100644
--- a/arch/x86_64/kernel/genapic_flat.c
+++ b/arch/x86_64/kernel/genapic_flat.c
@@ -33,7 +33,7 @@ static cpumask_t flat_vector_allocation_
         * hyperthread was specified in the interrupt desitination.
         */
        cpumask_t domain = { { [0] = APIC_ALL_CPUS, } };
-       return domain;
+       return cpu_online_map;
 }
 
 /*
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/