Re: [RFD][PATCH 2/2] sysctl: Implement CTL_UNNUMBERED

[Kyle Moffett]

On Oct 23, 2006, at 03:25:13, Eric W. Biederman wrote:
> --- a/fs/lockd/svc.c
> -/* Something that isn't CTL_ANY, CTL_NONE or a value that may  
> clash. */
> -#define CTL_UNNUMBERED		-2
> -

> --- a/fs/nfs/sysctl.c
> -/*
> - * Something that isn't CTL_ANY, CTL_NONE or a value that may clash.
> - * Use the same values as fs/lockd/svc.c
> - */
> -#define CTL_UNNUMBERED -2

> +++ b/include/linux/sysctl.h
>  #ifdef __KERNEL__
>  #define CTL_ANY		-1	/* Matches any name */
>  #define CTL_NONE	0
> +#define CTL_UNNUMBERED	CTL_NONE	/* sysctl without a binary number */
>  #endif

This change looks totally broken.  Before this patch, CTL_UNNUMBERED  
== -2, a number that isn't CTL_ANY, CTL_NONE, or a valid sysctl  
number.  After this patch, CTL_UNNUMBERED == 0, or CTL_NONE.

Cheers,
Kyle Moffett

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/