Re: [PATCH] Freeze bdevs when freezing processes.

[Andrew Morton]

> On Mon, 23 Oct 2006 19:14:50 +0200 Pavel Machek <pavel@xxxxxx> wrote:
> On Mon 2006-10-23 09:55:22, Andrew Morton wrote:
> > > On Mon, 23 Oct 2006 16:07:16 +0200 "Rafael J. Wysocki" <rjw@xxxxxxx> wrote:
> > > > I'm trying to prepare the patches to make swsusp into suspend2.
> > > 
> > > Oh, I see.  Please don't do that.
> > 
> > Why not?
> 
> Last time I checked, suspend2 was 15000 lines of code, including its
> own plugin system and special user-kernel protocol for drawing
> progress bar (netlink based). It also did parts of user interface from

That's different.

I don't know where these patches are leading, but thus far they look like
reasonable cleanups and generalisations.  So I suggest we just take them
one at a time.

> 
> OTOH, that was half a year ago, but given that uswsusp can now do most
> of the stuff suspend2 does (and without that 15000 lines of code), I
> do not think we want to do complete rewrite of swsusp now.

uswsusp seems like a bad idea to me.  We'd be better off concentrating on a
simple, clean in-kernel thing which *works*.  Right now the main problems
with swsusp are that it's slow and that there are driver problems. 
(Actually these are both driver problems).

Fiddling with the top-level interfaces doesn't address either of these core
problems.

Apparently uswsusp has gained support for S3 while the in-kernel driver
does not support S3.  That's disappointing.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/