Re: [KJ] [PATCH] Correct misc_register return code handling in several drivers

From: Dan Carpenter
Date: Mon Oct 23 2006 - 14:01:58 EST


On 10/23/06, Neil Horman <nhorman@xxxxxxxxxxxxx> wrote:
+out3:
+ for_each_online_node(node) {
+ if(timers[node] != NULL)
+ kfree(timers[node]);
+ }

Tharindu is going to be unhappy out if he sees that. There is a
possibility that timers[node] is uninitialized. if node[0] is null
then node[1] is uninitialized and it's going to cause a crash.

regards,
dan carpenter
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/