RE: [PATCH] x86_64 irq: reuse vector for set_xxx_irq_affinityin phys flat mode
From: Lu, Yinghai
Date: Mon Oct 23 2006 - 17:00:43 EST
From: ebiederm@xxxxxxxxxxxx [mailto:ebiederm@xxxxxxxxxxxx]
>Beyond that I have a few nits to pick with the patch.
>- We duplicate the code that claims a new vector which makes
> maintenance a pain.
>- The comments are specific to phys_flat but the code is not.
>- The test for being able to use the old_vector in the new domain
> should be: ...[old_vector] == vector || ...[old_vector] == -1
Please attached one. This one need to after your patch about irq.
YH
Attachment:
io_apic_reuse_vector.diff
Description: io_apic_reuse_vector.diff