Re: [PATCH 2/7] paravirtualization: Patch inline replacements forcommon paravirt operations.

From: Andrew Morton
Date: Wed Nov 01 2006 - 18:28:38 EST


On Wed, 01 Nov 2006 21:28:13 +1100
Rusty Russell <rusty@xxxxxxxxxxxxxxx> wrote:

> +void apply_paravirt(struct paravirt_patch *start, struct paravirt_patch *end)
> +{
> + struct paravirt_patch *p;
> + int i;
> +
> + for (p = start; p < end; p++) {
> + unsigned int used;
> +
> + used = paravirt_ops.patch(p->instrtype, p->clobbers, p->instr,
> + p->len);
> +#ifdef CONFIG_DEBUG_KERNEL
> + /* Deliberately clobber regs using "not %reg" to find bugs. */

That would be considered to be abusive of CONFIG_DEBUG_KERNEL. A
CONFIG_DEBUG_PARAVIRT which depends on CONFIG_DEBUG_KERNEL would be more
harmonious.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/