Re: CONFIG_NO_HZ: missed ticks, stall (keyb IRQ required)[2.6.18-rc4-mm1]

From: Thomas Gleixner
Date: Thu Nov 02 2006 - 03:13:23 EST


On Thu, 2006-11-02 at 08:31 +0100, Thomas Gleixner wrote:
> Does it resume normal operation after the "ACPI: lapic on CPU 0 stops in
> C2[C2]" message ?
>
> It is easy to fix by marking all AMDs broken again, but I really want to
> avoid this.

Doo, found a brown paperbag bug.

Index: linux-2.6.19-rc4-mm1/drivers/acpi/processor_idle.c
===================================================================
--- linux-2.6.19-rc4-mm1.orig/drivers/acpi/processor_idle.c 2006-11-02 08:01:52.000000000 +0100
+++ linux-2.6.19-rc4-mm1/drivers/acpi/processor_idle.c 2006-11-02 09:09:23.000000000 +0100
@@ -575,8 +575,8 @@ static void acpi_processor_idle(void)
*/
if (pr->power.timer_state_unstable <
pr->power.timer_broadcast_on_state) {
- pr->power.timer_state_unstable =
- pr->power.timer_broadcast_on_state;
+ pr->power.timer_broadcast_on_state =
+ pr->power.timer_state_unstable;
acpi_propagate_timer_broadcast(pr);
}



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/