Re: [PATCH 1/8] cciss: version number change

[Jens Axboe]

On Thu, Nov 02 2006, Arjan van de Ven wrote:
> On Thu, 2006-11-02 at 08:46 -0600, Mike Miller (OS Dev) wrote:
> > On Thu, Nov 02, 2006 at 03:10:45PM +0100, Jens Axboe wrote:
> > > On Wed, Nov 01 2006, Mike Miller (OS Dev) wrote:
> > > > 
> > > > PATCH 1/8
> > > > 
> > > > This patch changes the cciss version number to 3.6.14 to reflect the following
> > > > functionality changes added by the rest of the set. They include:
> > > 
> > > Mike, only some of your patches appeared to go out, both in personal
> > > mail and on the list.
> > 
> > I ran into some last minute issues so I stopped at 5. Still re-testing
> > the others.
> > This snippet seems to tbe the culprit.
> > +               if (blk_queue_stopped(h->gendisk[curr_queue]->queue) ||
> > +                   blk_queue_plugged(h->gendisk[curr_queue]->queue))
> > +                       blk_start_queue(h->gendisk[curr_queue]->queue);
> > 
> > We're testing to see if the queue is stopped or plugged so we don't
> > try to start am already running queue. Without the blk_queue_plugged
> > test it hangs every time. We added blk_queue_plugged and the first tests
> > seem to run ok. Then at the last minute something broke. Does this look
> > ok to you?
> 
> 
> it looks like a design mistake to me if a device driver needs to care
> about a queue being plugged at all....

The queue can't be plugged and stopped at the same time anyway, so the
code is confusing. But yes I agree, that should go.

-- 
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/