Re: [PATCH 2/3] fsstack: Generic get/set lower object functions

[Trond Myklebust]

On Thu, 2006-11-02 at 22:51 -0500, Josef Sipek wrote:
> On Fri, Nov 03, 2006 at 03:45:50AM +0000, Mark Williamson wrote:
> > > > Why are you defining all these structs that are just wrapping unions?
> > >
> > > The reason for the union is simple...
> ...
> > I guess that having a union foo * rather than a struct foo * would be a bit 
> > unconventional in the kernel.  The named struct / anonymous union combo does 
> > hide the union as merely an implementation detail, which is nice.  Was this 
> > your motivation?
> 
> That's exactly it. Save space & hide the details.

Why? What is so special about the details that you need to hide them?
This is a union that will always be part of a structure anyway.

Trond

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/