Re: [PATCH] airo.c: check returned values

[Jeff Garzik]

Florin Malita wrote:
> create_proc_entry() can fail and return NULL in setup_proc_entry(), the
> result must be checked before dereferencing. (Coverity ID 1443)
>
> init_wifidev() & setup_proc_entry() can also fail in _init_airo_card().
>
> This adds the checks & cleanup code and removes some whitespace.
>
> Signed-off-by: Florin Malita <fmalita@xxxxxxxxx>

NAK:  create_proc_entry() is complicated.  You are correct it can fail 
-- but to add to the confusion, when CONFIG_PROC_FS is disabled, the 
wrapper will also return NULL -- which is NOT a failure case.

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/