Re: [PATCH 2.6.19-rc4] usb auerswald possible memleak fix

From: Mariusz Kozlowski
Date: Tue Nov 07 2006 - 04:26:31 EST


Witam,

> On Tue, Nov 07, 2006 at 12:31:51AM +0100, Mariusz Kozlowski wrote:
> > Witam,
> >
> > > Hello,
> > >
> > > There is possible memleak in auerbuf_setup(). Fix is to replace kfree() with auerbuf_free().
> > > An argument to usb_free_urb() does not need a check as usb_free_urb() already does that. Not sure if I should
> > > send this in two separate patches. The patch is against 2.6.19-rc4 (not -mm).
> >
> > As I posted the bigger usb_free_urb() patch in another mail this one
> > should do only one thing which is to fix possible memory leak in
> > auerbuf_setup().
>
> That is a big patch, care to split it up into smaller pieces like this
> one so that it is easier to review and apply?

Sure I can but Andrew already included it in -mm as-is. Do I have to prepare another set of patches
and send them to you (which is no problem to me - just not sure how it works)?

Regards,

Mariusz Kozlowski

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/