Re: very small code cleanup

[Hugh Dickins]

On Tue, 7 Nov 2006, Paulo Marques wrote:
> Rik Bobbaers wrote:
> > 
> > in mm/mlock.c , mm is defined as vma->vm_mm, why not use that one for the
> > decrement of pages?
> 
> Because vma can change here:
> 
> 	if (*prev) {
> 		vma = *prev;
> 		goto success;
> 	}

That's a good piece of cautious observation ...

> 
> and then mm won't be the same as vma->vm_mm..

... but it would be a bug if *prev's vm_mm were different from mm
and from the original vma->vm_mm: Rik's patch looks sensible to me.

Hugh
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/