Re: [PATCH] gx-suspmod: fix "&& 0xff" typo

From: Dave Jones
Date: Wed Nov 08 2006 - 17:17:09 EST


On Wed, Nov 08, 2006 at 02:10:07PM -0800, Randy Dunlap wrote:
> On Thu, 9 Nov 2006 01:04:35 +0300 Alexey Dobriyan wrote:
>
> > Signed-off-by: Alexey Dobriyan <adobriyan@xxxxxxxxx>
> > ---
> >
> > arch/i386/kernel/cpu/cpufreq/gx-suspmod.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > --- a/arch/i386/kernel/cpu/cpufreq/gx-suspmod.c
> > +++ b/arch/i386/kernel/cpu/cpufreq/gx-suspmod.c
> > @@ -473,7 +473,7 @@ static int __init cpufreq_gx_init(void)
> > pci_read_config_byte(params->cs55x0, PCI_MODON, &(params->on_duration));
> > pci_read_config_byte(params->cs55x0, PCI_MODOFF, &(params->off_duration));
> > pci_read_config_dword(params->cs55x0, PCI_CLASS_REVISION, &class_rev);
> > - params->pci_rev = class_rev && 0xff;
> > + params->pci_rev = class_rev & 0xff;
>
> Hi,
> any kind of automated detection on that one?

grep -r "&& 0x" . seems to be pretty effective modulo
some false-positives.

Dave

--
http://www.codemonkey.org.uk
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/