Re: [RFC] [PATCH] Fix misrouted interrupts deadlocks

[Ingo Molnar]

On Fri, 2006-11-10 at 16:55 +0300, Pavel Emelianov wrote:
> -                       int ok = misrouted_irq(irq);
> +                       int ok;
> +
> +                       spin_unlock(&desc->lock);
> +                       ok = misrouted_irq(irq);
> +                       spin_lock(&desc->lock); 

your fix looks reasonable to me - it's a thinko to call misrouted_irq()
with the descriptor lock still held. (btw., how did you find it -
lockdep spinlock debugging or NMI watchdog?)

Acked-by: Ingo Molnar <mingo@xxxxxxxxxx>

	Ingo

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/