Re: [patch] genapic: optimize & fix APIC mode setup

[Andi Kleen]

On Monday 13 November 2006 09:16, Ingo Molnar wrote:
> 
> * Andi Kleen <ak@xxxxxxx> wrote:
> 
> > Now if it causes device driver issues that's different of course. I 
> > wasn't aware of this before.
> 
> lets try my patch in -mm for a while.

I don't think that's a good idea.

> 
> Had i ever noticed this hack in the first place i would have NAK-ed it. 
> There is a fundamental design friction of a high-level feature like 
> HOTPLUG_CPU /requiring/ a fundamental change to the lowlevel IRQ 
> delivery mode! 

Well to be honest masked mode isn't that useful anyways. It's only
theoretical advantage would be a bit more performance for multicast IPIs, 
but Ashok did benchmarks and it didn't make any significant difference. With that
I prefer to use always the same mode for small and large systems.
Ok should probably drop the ifdef and just always use physical mode.


> Such a requirement is broken and just serves to hide a  
> flaw in the hotplug design - which flaw would trigger on i386 /anyway/, 
> because i386 still uses logical delivery mode for APIC IPIs. 

i386 cpu hotplug is somewhat broken anyways, but it should be fixed
there too eventually. But some very old chipsets don't seem to support
physical properly so it wasn't changed there.

> Also, i'd  
> like to have a description of how to reproduce those CPU hotplug 
> problems, so that i can try to fix it.

iirc they just did stress tests. Plug/unplug cpus in a tight loop and 
do some workloads and see what happens.

-Andi
 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/