[PATCH] Re: linux-2.6.19-rc5-g088406bc build #120 failed

[Jeff Garzik]

Toralf Förster wrote:
> Hello,
>
> the build with the attached .config failed, make ends with:
> ... 
> UPD     include/linux/compile.h
>   CC      init/version.o
>   LD      init/built-in.o
>   LD      .tmp_vmlinux1
> drivers/built-in.o: In function `hdlcdev_open':
> synclink.c:(.text+0x650d5): undefined reference to `hdlc_open'
> synclink.c:(.text+0x6510d): undefined reference to `hdlc_open'
> ...
> synclink_cs.c:(.text+0x7aece): undefined reference to `hdlc_ioctl'
> drivers/built-in.o: In function `hdlcdev_init':
> synclink_cs.c:(.text+0x7b336): undefined reference to `alloc_hdlcdev'
> drivers/built-in.o: In function `hdlcdev_exit':
> synclink_cs.c:(.text+0x7b434): undefined reference to `unregister_hdlc_device'
> make: *** [.tmp_vmlinux1] Error 1

Does this patch work for you?

	Jeff


diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig
index 39a9f8c..5ac61e1 100644
--- a/drivers/char/Kconfig
+++ b/drivers/char/Kconfig
@@ -213,7 +213,7 @@ config ISI
 
 config SYNCLINK
 	tristate "Microgate SyncLink card support"
-	depends on SERIAL_NONSTANDARD && PCI && ISA_DMA_API
+	depends on SERIAL_NONSTANDARD && PCI && ISA_DMA_API && HDLC
 	help
 	  Provides support for the SyncLink ISA and PCI multiprotocol serial
 	  adapters. These adapters support asynchronous and HDLC bit
@@ -226,7 +226,7 @@ config SYNCLINK
 
 config SYNCLINKMP
 	tristate "SyncLink Multiport support"
-	depends on SERIAL_NONSTANDARD
+	depends on SERIAL_NONSTANDARD && HDLC
 	help
 	  Enable support for the SyncLink Multiport (2 or 4 ports)
 	  serial adapter, running asynchronous and HDLC communications up
diff --git a/drivers/char/pcmcia/Kconfig b/drivers/char/pcmcia/Kconfig
index 27c1179..2b852bf 100644
--- a/drivers/char/pcmcia/Kconfig
+++ b/drivers/char/pcmcia/Kconfig
@@ -7,7 +7,7 @@ menu "PCMCIA character devices"
 
 config SYNCLINK_CS
 	tristate "SyncLink PC Card support"
-	depends on PCMCIA
+	depends on PCMCIA && HDLC
 	help
 	  Enable support for the SyncLink PC Card serial adapter, running
 	  asynchronous and HDLC communications up to 512Kbps. The port is