Re: [PATCH] x86_64: fix perms/range of vsyscall vma in /proc/*/maps

From: Andi Kleen
Date: Mon Nov 13 2006 - 21:53:19 EST


On Tuesday 14 November 2006 03:51, Ernie Petrides wrote:
> On Friday, 10-Nov-2006 at 6:07 +0100, Andi Kleen wrote:
>
> > On Friday 10 November 2006 02:20, Ernie Petrides wrote:
> >
> > > Hi, Andi. The final line of /proc/<pid>/maps on x86_64 for native 64-bit
> > > tasks shows an incorrect ending address and incorrect permissions. There
> > > is only a single page mapped in this vsyscall region, and it is accessible
> > > for both read and execute.
> >
> > The range reported is how much address space is reserved, but you're
> > right it is less.
> >
> > But I don't like hardcoding a page here -- this will likely be extended
> > soon. Can you please create a new define VSYSCALL_REAL_LENGTH or similar
> > in vsyscall.h and use that?
>
> Good idea -- how about the patch below?

Added thanks. Probably for .20, i don't think it's critical enough for .19
unless someone feels strongly about it.

-Andi

P.S.: When you retransmit patches please always include the original description
for the changelog too.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/