[PATCH] i386: conditionalize touching of memory intouch_nmi_watchdog()

From: Jan Beulich
Date: Wed Nov 15 2006 - 09:56:35 EST


Just like on x86-64, don't touch foreign CPUs' memory if the watchdog
isn't enabled at all.

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>

--- linux-2.6.19-rc5/arch/i386/kernel/nmi.c 2006-11-08 09:21:37.000000000 +0100
+++ 2.6.19-rc5-i386-touch_nmi_watchdog/arch/i386/kernel/nmi.c 2006-11-06 09:10:16.000000000 +0100
@@ -867,14 +867,16 @@ static unsigned int

void touch_nmi_watchdog (void)
{
- int i;
+ if (nmi_watchdog > 0) {
+ unsigned cpu;

- /*
- * Just reset the alert counters, (other CPUs might be
- * spinning on locks we hold):
- */
- for_each_possible_cpu(i)
- alert_counter[i] = 0;
+ /*
+ * Just reset the alert counters, (other CPUs might be
+ * spinning on locks we hold):
+ */
+ for_each_present_cpu (cpu)
+ alert_counter[cpu] = 0;
+ }

/*
* Tickle the softlockup detector too:


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/