Re: [PATCH 3/3] KVM: Expose MSRs to userspace

[Avi Kivity]

Andrew Morton wrote:
> On Fri, 17 Nov 2006 09:20:49 +0200
> Avi Kivity <avi@xxxxxxxxxxxx> wrote:
>
>   
> > > > +out_vcpu:
> > > > +	vcpu_put(vcpu);
> > > > +
> > > > +	return rc;
> > > > +}
> > > >     
> > > >         
> > > This function returns no indication of how many msrs it actually did set. 
> > > Should it?
> > >   
> > >       
> > It can't hurt.  Is returning the number of msrs set in the return code 
> > (ala short write) acceptable, or do I need to make this a read/write ioctl?
> >
> >     
>
> I'd have thought that you'd just copy the number written into msrs->nmsrs via
>
> 	msrs->nmsrs = num_entries;
>
> like kvm_dev_ioctl_set_msrs() does.  Dunno...
>   

It means making it an _IOWR() ioctl, but no matter.

--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/