Re: [PATCH] 2.6.18-rt7: PowerPC: fix breakage in threaded fasteoitype IRQ handlers

[Sergei Shtylyov]

Hello.

Benjamin Herrenschmidt wrote:

> > * Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx> wrote:

> > > Wait wait wait .... Can somebody (Ingo ?) explain me why the fasteoi 
> > > handler is being changed and what is the rationale for adding an ack 
> > > that was not necessary before ?

> > dont worry, it's -rt only stuff.

> Still, I'm curious :-) Besides, there have been people talking about
> having -rt work on ppc64 so ...

> What do you need an ack() for on fasteoi ? On all fasteoi controllers I
> have, ack is implicit by obtaining the vector number and all there is is
> an eoi...

   I must not that this whole ack() vs eoi() stuff is misleading. For example,
in 8259 driver, mask_ack() method actually sends EOI to PIC, not ACK's an IRQ 
-- the actual ACK is implicit on x86 and is used to read the interrupt vector 
form 8259 on PPC. So, IMO, there probably should only have been either ack() 
or eoi() method in the first place. Though I'm not familiar with ARM from 
which genirq stuff originated...

> Cheers,
> Ben.

WBR, Sergei
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/