Re: [PATCH 001/001] i386/pci: fix nibble permutation and add Cyrix 5530 IRQ router

[Juergen Beisert]

Hi Alan,

On Friday 24 November 2006 12:41, Alan wrote:
> On Fri, 24 Nov 2006 11:44:05 +0100
>
> > Cyrix 5520 and Cyrix 5530 do interrupt routing in the same way. But the
> > (pirq-1)^1 expression to set a route always sets the wrong nibble, so
> > INTA/INTB and INTC/INTD are permuted and do not work as expected.
> >
> > Signed-off-by: Juergen Beisert <juergen.beisert@xxxxxxxxxxxxxxxxx>
>
> NAK
>
> This will then break other boards. As far as I can tell there is no
> "correct" answer here for 5530 based hardware. The existing setup makes
> most random CS5520/30 based PC systems like the Palmax laptops work if the
> irq router is used, your change will break them

Hmmmm, as I understand the source, it let the routing register entries 
unchanged if the BIOS did it before. This is why it (IMHO) works. But if this 
routine tries to set a new route it fails due to it writes the wrong register 
nibble. But maybe I'm wrong, I will read the source again (and try to get a 
CS5520 datasheet).

> Given the choice between LinuxBIOS and the rest of the world then the
> rest of the world needs to win.

ACK. :-)

Juergen
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/