Re: [patch] x86: unify/rewrite SMP TSC sync code

From: Andi Kleen
Date: Fri Nov 24 2006 - 12:13:53 EST



> make the TSC synchronization code more robust, and unify it between
> x86_64 and i386.
>
> The biggest change is the removal of the 'fix up TSCs' code on x86_64
> and i386, in some rare cases it was /causing/ time-warps on SMP systems.

On x86-64 I don't think it can since it doesn't check anymore on sync Intel.

> The new code only checks for TSC asynchronity - and if it can prove a
> time-warp (if it can observe the TSC going backwards when going from one
> CPU to another within a critical section), then the TSC clock-source is
> turned off.

The trouble is that people are using the RDTSC anyways even if the
kernel doesn't. So some synchronization is probably a good idea.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/