Re: [PATCH] Avoid truncating to 'long' in ALIGN() macro

[David Miller]

From: Roland Dreier <rdreier@xxxxxxxxx>
Date: Sat, 25 Nov 2006 14:56:22 -0800

>  > Perhaps a better way to fix this is to use
>  > typeof() like other similar macros do.
> 
> I tried doing
> 
> #define ALIGN(x,a)				\
> 	({					\
> 		typeof(x) _a = (a);		\
> 		((x) + _a - 1) & ~(_a - 1);	\
> 	})
> 
> but that won't compile because of <net/neighbour.h>:

You would need to also cast the constants with typeof() to.

But yes, given the array sizing case in the neighbour code,
perhaps we can use your original patch for now.  Feel free
to push that to Linus.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/