Re: [RFC: 2.6 patch] remove the broken MTD_PCMCIA driver

[Adrian Bunk]

On Tue, Nov 28, 2006 at 10:16:27PM +0000, David Woodhouse wrote:
> On Sat, 2006-11-18 at 22:40 +0100, Adrian Bunk wrote:
> > The MTD_PCMCIA driver has:
> > - already been marked as BROKEN in 2.6.0 three years ago and
> > - is still marked as BROKEN.
> > 
> > Drivers that had been marked as BROKEN for such a long time seem to be
> > unlikely to be revived in the forseeable future.
> 
> Actually, there's hardware currently on its way to me, and I plan to fix
> this driver fairly soon.

OK.

> > But if anyone wants to ever revive this driver, the code is still
> > present in the older kernel releases.
> 
> I'm unconvinced by that argument in the general case. People don't go
> looking back through git history, do they? Drivers such as this don't
> really do any harm as they are, and they're _much_ easier to find when
> someone does want to fix them up.

If there is an already merged driver that is marked as broken for a long 
time, there are usually two possible cases:
- it is really unused
- patches to fix it are pending or floating around

A patch to remove a driver is usually the best way for getting the 
information which case a driver belongs into (a good example might be 
the zr36120 driver that seems to have found a new maintainer due to my 
removal patch).

And if there's no reaction, the usefullness of very outdated and 
usually non-compiling code is quite questionable.

> dwmw2

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/