Re: [RFC][PATCH] Mount problem with the GFS2 code

[Andrew Morton]

On Thu, 30 Nov 2006 15:04:55 +0530
Srinivasa Ds <srinivasa@xxxxxxxxxx> wrote:

> ==========================================================================
> On debugging further we found that problem is while reading the super 
> block(gfs2_read_super) and comparing the magic number in it.
> When I  replace the submit_bio() call(present in gfs2_read_super) with 
> the sb_getblk() and ll_rw_block(), mount operation succeded.

umm, why on earth does gfs2_read_super() go direct-to-BIO?

Switching to sb_getblk()+ll_rw_blk() sounds like a preferable fix.

Even better would be switching to a bare sb_bread().   If sb->s_blocksize
isn't set up by then then either set it up or, if you must, use __bread().

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/