Re: [PATCH] rtc: ds1743 support

[Alessandro Zummo]

On Thu, 30 Nov 2006 08:12:02 +0100
Torsten Ertbjerg Rasmussen <tr@xxxxxxxxx> wrote:

> The real time clocks ds1742 and ds1743 differs only in the size of the nvram. 
> This patch changes the existing ds1742 driver to support also ds1743. The 
> main change is that the nvram size is determined from the resource attached 
> to the device. 


> +	pdata->ioaddr_rtc = ioaddr + pdata->size_nvram;
>  
>  	/* turn RTC on if it was not on */
> +	ioaddr = pdata->ioaddr_rtc;
>  	sec = readb(ioaddr + RTC_SECONDS);

 why not
	sec = readb(pdata->ioaddr_rtc + RTC_SECONDS);
?


 Acked-by: Alessandro Zummo <a.zummo@xxxxxxxxxxxx>

-- 

 Best regards,

 Alessandro Zummo,
  Tower Technologies - Turin, Italy

  http://www.towertech.it

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/