Re: Let's get rid of those annoying "VFS is out of sync with lock manager" messages (includes proposed patch)

From: Jesper Juhl
Date: Fri Dec 08 2006 - 09:49:39 EST


On 08/12/06, Jesper Juhl <jesper.juhl@xxxxxxxxx> wrote:
On 08/12/06, Neil Brown <neilb@xxxxxxx> wrote:
> On Thursday December 7, jesper.juhl@xxxxxxxxx wrote:
> >
> > So I took Neils patch, made the change Trond suggested and the result is
> > below.
> >
> > Comments? Ok to merge?
>
> Yes, except that you need a changelog comment at the top. Possibly
> based very heavily on the text I wrote, but written to justify the
> patch rather than to explain the bug.
>
> NeilBrown
>

How about this for a changelog entry? :

Convert "VFS is out of sync with lock manager!" printk in
do_vfs_lock() to dprintk() since the message is useless in normal use
but could possibly be useful as a debugging aid.
Also turn off FL_SLEEP when calling do_vfs_lock() just in case after
getting -EINTR or -ERESTARTSYS.


Ohh and btw, I forgot to mention that the patch has been tested and
resolves my original issue.

--
Jesper Juhl <jesper.juhl@xxxxxxxxx>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/