Re: [PATCH 11/12] IPMI: Fix BT long busy

[Andrew Morton]

On Fri, 08 Dec 2006 06:03:59 -0700
Rocky Craig <rocky.craig@xxxxxx> wrote:

> Andrew Morton wrote:
> 
> >In fact, please don't write macros.
> >  
> >
> I see them all over the place (i.e., EXPORT_SYMBOL) so the request
> is a little confusing to me...

It's a general principle.  Sometimes they're unavoidable.  Other times they
are avoidable but people add them anyway.

> > Please don't write macros which require that the caller have a particular
> >
> >local variable of a particular name.
> >  
> >
> I could understand that, even if some people did agree with my desire
> to increase legibility by decreasing visual clutter.  I think it also 
> provides
> some protection against typos in argument lists.
> 
> I'm (naively) curious as to why it's being flagged now as opposed to
> two years ago when I submitted the original additions.

It probably didn't get noticed.  Some of the stuff we have in there is
unbelieveable.

> Have reviewers or review methods changed?
> 
> Have standards changed?

We have become more vigilant over time.

> Did it just slip under someone's radar two years ago?

I'd say so, yes.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/