Re: [patch 1/2] agpgart - allow user-populated memory types.

From: Arjan van de Ven
Date: Fri Dec 08 2006 - 17:04:04 EST


On Fri, 2006-12-08 at 19:24 +0100, Thomas HellstrÃm wrote:
>
> +void agp_generic_free_user(struct agp_memory *curr)
> +{
> + if ((unsigned long) curr->memory >= VMALLOC_START
> + && (unsigned long) curr->memory < VMALLOC_END) {
> + vfree(curr->memory);
> + } else {
> + kfree(curr->memory);
> + }
> + agp_free_key(curr->key);
> + kfree(curr);


why? this really is almost too ugly to live ;(

> +}
> +EXPORT_SYMBOL(agp_generic_free_user);
> +
--
if you want to mail me at work (you don't), use arjan (at) linux.intel.com
Test the interaction between Linux and your BIOS via http://www.linuxfirmwarekit.org

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/