Re: [RFC] [PATCH] virtual memmap on sparsemem v3 [1/4] map andunmap

[KAMEZAWA Hiroyuki]

On Fri, 8 Dec 2006 16:28:19 -0800
Andrew Morton <akpm@xxxxxxxx> wrote:

> Generally we prefer to simply *require* that the function vector be filled
> in appropriately.  So if the caller has no special needs, the caller will
> set their gen_map_kern_ops.k_pte_alloc to point at pte_alloc_kernel().
> 
> erk, pte_alloc_kernel() is a macro.  As is pmd_alloc(), etc.  Well, let
> that be a lesson to us.  What a mess.
> 
> I suppose we could go through and convert them all to inlines and then the
> compiler will generate an out-of-line copy for us.  Better would be to turn
> these things into regular, out-of-line C functions.
> 
> What a mess.
> 

Thank you for review. I'll remove this default action.

-Kame

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/