Re: [RFC] [PATCH] virtual memmap on sparsemem v3 [3/4] staticvirtual mem_map

[KAMEZAWA Hiroyuki]

On Fri, 8 Dec 2006 16:30:20 -0800
Andrew Morton <akpm@xxxxxxxx> wrote:

> > +#ifdef CONFIG_SPARSEMEM_VMEMMAP_STATIC
> > +#include <linux/mm_types.h>
> > +extern struct page mem_map[];
> > +#else
> >  extern struct page* mem_map;
> >  #endif
> > +#endif
> 
> This looks rather unpleasant - what went wrong here?
> 
definition of 'struct page' is necessary before declearing array[]. (for gcc-4.0)

> Would prefer to unconditionally include the header file - conditional inclusions
> like this can cause compile failures when someone changes a config option.  They
> generally raise the complexity level.
>
Okay.
Now, forward declearation of 'struct page' is in mmzone.h. 
I'll remove it and include mm_types.h instead of it.
If someone says "Don't do that", I'll look for anothere way.

-Kame


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/