Re: RFC: PCI quirks update for 2.6.16

[Adrian Bunk]

On Sun, Dec 10, 2006 at 04:09:39AM +0000, Sergio Monteiro Basto wrote:
> On Thu, 2006-12-07 at 09:38 -0500, Daniel Drake wrote:
> > Adrian Bunk wrote:
> > > Daniel Drake (1):
> > >       PCI: VIA IRQ quirk behaviour change
> > 
> > Please drop this one, Alan isn't 100% on it and is working on getting a 
> > better fix into mainline
> > 
> > Daniel
> 
> Sorry Daniel, I don't agree with you, this patch is a improvement of the
> original patch and in my opinion should go in.
> As Alan explain to us, is not the prefect one, but still be an
> improvement.

Below is the patch for going back to the 2.6.16.16 status quo that is in 
2.6.16.36-rc1.

Does this cause any serious regression for anyone?

> Thanks,
> Sérgio M. B. 

cu
Adrian


commit dcb1715778026c4aec20d186dc794245d9a1f5de
Author: Adrian Bunk <bunk@xxxxxxxxx>
Date:   Fri Dec 8 17:00:35 2006 +0100

    revert the quirk_via_irq changes
    
    This patch reverts the quirk_via_irq changes in 2.6.16.17 that
    caused regressions for several people.
    
    Signed-off-by: Adrian Bunk <bunk@xxxxxxxxx>

diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index a1cdf06..2a66e39 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -656,13 +656,7 @@ static void quirk_via_irq(struct pci_dev *dev)
 		pci_write_config_byte(dev, PCI_INTERRUPT_LINE, new_irq);
 	}
 }
-DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C586_0, quirk_via_irq);
-DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C586_1, quirk_via_irq);
-DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C586_2, quirk_via_irq);
-DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C586_3, quirk_via_irq);
-DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C686, quirk_via_irq);
-DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C686_4, quirk_via_irq);
-DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C686_5, quirk_via_irq);
+DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_ANY_ID, quirk_via_irq);
 
 /*
  * VIA VT82C598 has its device ID settable and many BIOSes
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/