Re: [patch] pipe: Don't oops when pipe filesystem isn't mounted

From: Al Viro
Date: Mon Dec 11 2006 - 05:48:22 EST


On Mon, Dec 11, 2006 at 02:34:36AM -0800, Andrew Morton wrote:

> There are plenty of drivers in there using subsys_initcall, arch_initcall,
> postcore_initcall, core_initcall and even one pure_initcall.
>
> Heaven knows why. They're drivers :(

> A heck of a lot of things can trigger an /sbin/hotplug run. It could well
> be that Andrew's driver didn't want to run hotplug at all, but the kernel
> did it anwyay. But as soon as the script appeared at /sbin/hotplug, and it
> happened to use foo|bar: boom.

Again, I agree with moving pipes up, but keep in mind that any caller
of /sbin/hotplug either
* doesn't need it or
* really handles failure or
* really should _not_ be run before populate_rootfs()
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/