Re: [PATCH -rt][RESEND] spin lock imbalance in ibm emac

From: Daniel Walker
Date: Mon Dec 11 2006 - 11:05:41 EST


On Mon, 2006-12-11 at 16:59 +0100, Ingo Molnar wrote:
> * Daniel Walker <dwalker@xxxxxxxxxx> wrote:
>
> > On Mon, 2006-12-11 at 10:27 +0100, Ingo Molnar wrote:
> > > * Daniel Walker <dwalker@xxxxxxxxxx> wrote:
> > >
> > > > Sent this a long time ago, still exists.
> > > >
> > > > Signed-Off-By: Daniel Walker <dwalker@xxxxxxxxxx>
> > >
> > > hm, what does this do, and why isnt it upstream?
> >
> > AFAIK, those locks are added in -rt . I'm not sure how they got in
> > there, but they fix that driver when running in a thread. The driver
> > has unsafe SMP locking, but the only system it runs on (PPC4xx) is
> > uniprocessor. So it's not broken upstream per se.
>
> ok, i've applied your patch.


What about the OMAP fix? that one's been sitting around for a while too.

Daniel

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/