Re: [PATCH -rt][RESEND] fix preempt hardirqs on OMAP

[Ingo Molnar]

* Daniel Walker <dwalker@xxxxxxxxxx> wrote:

> +	/*
> +	 * Some boards will disable an interrupt when it
> +	 * sets IRQ_PENDING . So we have to remove the flag
> +	 * and re-enable to handle it.
> +	 */
> +	if (desc->status & IRQ_PENDING) {
> +		desc->status &= ~IRQ_PENDING;
> +		if (desc->chip)
> +			desc->chip->enable(irq);
> +		goto restart;
> +	}

what if the irq got disabled meanwhile? Also, chip->enable is a 
compatibility method, not something we should use in a flow handler.

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/