Re: [PATCH -rt][RESEND] fix preempt hardirqs on OMAP

[Daniel Walker]

On Mon, 2006-12-11 at 19:54 +0000, Russell King wrote:

> > > what if the irq got disabled meanwhile? Also, chip->enable is a 
> > > compatibility method, not something we should use in a flow handler.
> > 
> > I don't know how other arches deal with IRQ_PENDING, but ARM (OMAP at
> > least) disables the IRQ on IRQ_PENDING.
> 
> Please point out where it's doing that, and I'll take a look to see
> if it's doing something it shouldn't.

It's in arch/arm/plat-omap/gpio.c . It uses the lowlevel function to
disable the interrupt, not chip->disable() . In gpio_irq_handler() .

Daniel

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/