Re: [PATCH -mm] sata_nv: fix kfree ordering in remove

From: Jeff Garzik
Date: Tue Dec 12 2006 - 06:35:46 EST


Robert Hancock wrote:
Jeff Garzik wrote:
It is unwise to free the struct before the ports are even detached.

Right, theoretically something bad could happen here (though not likely). Here's a fix. Sorry for attaching with something so trivial, but Thunderbird isn't very cooperative..

You'll need to resend the entire patch, I dropped it due to that comment. In general, before a patch is applied, the patch will go through several revisions. I don't apply things piecemeal, only the last (hopefully perfect:)) revision.

Also, as your email already guessed, attachments are to be avoided :/

Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/