Re: hi, should these code is a problem in nfs system clnt.c?

[Trond Myklebust]

On Tue, 2006-12-12 at 09:00 -0500, Peter Staubach wrote:
> linuxer linuxer wrote:
> > Hi, everyone: 
> >     I am a newbie, if my question waste your time, I
> > am sorry for that. 
> >
> >     In clnt.c file ,call_timeout function:    
> >     I suggest the code that judge whether the network
> > link status is down should be added, won't they? 
> >     I tested it with one Ethernet netcard.
> >
> >   
> 
> This would not be a good idea.  What happens if the name of the
> interface used on the system is not "eth0"?
> 
> Also, IP packets can be routed out of any available interface,
> so just because one interface (eth0) is down, doesn't mean
> that the entire system is networkless.

Right. Besides, it is also an obvious layering violation. Idea NAKed.

Trond

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/