Re: [PATCH 2.6.19] e1000: replace kmalloc with kzalloc

[Pekka Enberg]

On 12/12/06, Yan Burman <burman.yan@xxxxxxxxx> wrote:
>         size = txdr->count * sizeof(struct e1000_buffer);
> -       if (!(txdr->buffer_info = kmalloc(size, GFP_KERNEL))) {
> +       if (!(txdr->buffer_info = kzalloc(size, GFP_KERNEL))) {
>                 ret_val = 1;
>                 goto err_nomem;
>         }
> -       memset(txdr->buffer_info, 0, size);

No one seems to be using size elsewhere so why not convert to
kcalloc() and get rid of it? (Seems to apply to other places as well.)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/