Re: [patch 2/3] acpi: Add a docked sysfs file to the dock driver.

From: Kristen Carlson Accardi
Date: Tue Dec 12 2006 - 18:06:25 EST


On Tue, 12 Dec 2006 14:31:10 -0800
Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx> wrote:

> On Tuesday, December 12, 2006 2:15 pm, Stefan Schmidt wrote:
> > Hello.
> >
> > On Mon, 2006-12-11 at 12:05, Kristen Carlson Accardi wrote:
> > > On Sat, 9 Dec 2006 12:59:58 +0100
> > >
> > > Holger Macht <hmacht@xxxxxxx> wrote:
> > > > Well, I like to have them ;-)
> > >
> > > Ok - how is this?
> > >
> > > Send a uevent to indicate a device change whenever we dock or
> > > undock, so that userspace may now check the dock status via
> > > sysfs.
> >
> > I would like to have two different events for dock and undock.
> >
> > This way the userspace listener don't need to check the status file
> > in sysfs to know if there was a dock or undock after getting the
> > event.
> >
> > Anyway the status file is still usefull for programs don't react on
> > the events, but like to know if the laptop is docked before starting
> > for example.
>
> FWIW, Kay and Neil recently went back and forth regarding what sorts of
> events to generate for MD online/offline events. In concept md
> online/offline and dock/undock seem similar enough that the 'change'
> events Kay requested for md probably make sense in the dock/undock
> context as well, but I've Cc'd him just in case.
>
> Jesse
>

I did have different dock/undock events a few months ago - but
after some discussion we scrapped them because Kay wants to avoid driver
specific events. The "change" event is the only thing that makes sense,
given the set of uevents available right now, and userspace should be
able to handle checking a file to get driver specific details (i.e. dock
and undock status). If you have a specific reason why this won't work,
let me know.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/