Re: [RFC] Patch: dynticks: idle load balancing

From: Ingo Molnar
Date: Wed Dec 13 2006 - 18:34:16 EST



* Siddha, Suresh B <suresh.b.siddha@xxxxxxxxx> wrote:

> On Thu, Dec 14, 2006 at 12:13:16AM +0100, Ingo Molnar wrote:
> > there's another bug as well: in schedule() resched_cpu() is called with
> > the current runqueue held in two places, which is deadlock potential.
>
> resched_cpu() was getting called after prepare_task_switch() which
> releases the current runqueue lock. Isn't it?

no, it doesnt release it. The finish stage is what releases it.

the other problem is load_balance(): there this_rq is locked and you
call resched_cpu() unconditionally.

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/