Re: amd64 agpgart aperture base value

[Dave Jones]

On Wed, Dec 13, 2006 at 10:47:32PM -0500, Daniel Drake wrote:

 > In amd64-agp.c, would it be dangerous to remove the "aperture base > 4G" 
 > thing and instead simply only read the rightmost 7 bits to ensure the 
 > aperture base is always in range? (This is coming from someone with 
 > little AGPGART understanding...)

Ignoring the high bits is the wrong thing to be doing.
The BIOS placed the aperture in one place, and by masking bits, you're going
to be assuming its somewhere else, and scribbling over who knows what.

 > Alternatively do you have other suggestions for how the problem might be 
 > solved better?

If the aperture is placed above 4G, we should deal with it. Currently, we
don't. (See the AGP patches Linus merged just before 2.6.19 was released
that work around this for intel-agp).

Just needs someone to find the time to write the code to do it, and test it.

		Dave

-- 
http://www.codemonkey.org.uk
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/