Re: [PATCH] romsignature/checksum cleanup

From: Rene Herman
Date: Tue Dec 26 2006 - 19:47:38 EST


Rusty Russell wrote:

On Mon, 2006-12-25 at 01:53 +0100, Rene Herman wrote:

Hmm, by the way, if romsignature() needs this probe_kernel_address() thing, why doesn't romchecksum()?

I assume it's all in the same page, but CC'ing Zach is easier than
reading the code 8)

If we're talking hardware pages here; the romchecksum() might be done over an area upto 0xff x 512 = 130560 bytes (there's also an acces to the length byte at rom[2] in probe_roms(). I assume that one's okay if romsignature() ensured that the first page is in).

Rene.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/